Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copied froms for deprecated models #31153

Merged

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

Remove copied from statements for deprecated models.

As deprecated models are no longer tested, this prevents changes being propagated which aren't compatible with the current architecture which we would no longer catch.

Adds a line in the utils/deprecate_models.py script to remove these lines from the files automatically when deprecating

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, awesome! Thanks @amyeroberts!

@amyeroberts amyeroberts merged commit 5b5b48b into huggingface:main Jun 3, 2024
8 checks passed
@amyeroberts amyeroberts deleted the remove-copied-from-deprecated branch June 3, 2024 08:42
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
* Remove copied froms for deprecated models

* Remove automatically in script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants